chore: remove the hardcoded 2.21.3 version in dockerfile#568
Merged
joeyzhao2018 merged 2 commits intomainfrom Mar 4, 2025
Merged
chore: remove the hardcoded 2.21.3 version in dockerfile#568joeyzhao2018 merged 2 commits intomainfrom
joeyzhao2018 merged 2 commits intomainfrom
Conversation
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Co-authored-by: datadog-datadog-prod-us1[bot] <88084959+datadog-datadog-prod-us1[bot]@users.noreply.github.com>
mabdinur
approved these changes
Mar 4, 2025
mabdinur
changed the title
mabdinur
approved these changes
Mar 4, 2025
Collaborator
mabdinur
left a comment
mabdinur
left a comment
There was a problem hiding this comment.
Can we update the PR description to include why we needed to hard the ddtrace version
duncanista
reviewed
Mar 4, 2025
| # Install datadog_lambda and dependencies from local | ||
| COPY . . | ||
| RUN pip install . ddtrace==2.21.3 -t ./python/lib/$runtime/site-packages | ||
| RUN pip install --no-cache-dir . -t ./python/lib/$runtime/site-packages |
Contributor
There was a problem hiding this comment.
Is this safe to do? What's the implication of this? Do you remember why we were pinning before?
There was a pretty good reason about this from the past
Contributor
Author
There was a problem hiding this comment.
for ddtrace==2.21.3 it's in the description.
For just realized that @mabdinur merged the bot suggestion :P--no-cache-dir... i actually wonder how it was added ... my local change didn't have it
Contributor
There was a problem hiding this comment.
Ah, that's the reason, you were pinning in the past you wanted to make sure the fix was included for dynamodb, sg
duncanista
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We had to release a datadog-lambda-py layer with ddtrace 2.21.3 before releasing a layer with ddtrace v3. Related PR: #565
Now reverting the hardcoded ddtrace version in the docker file.
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply